[jboss-jira] [JBoss JIRA] (WFCORE-3181) Review CustomCredentialSecurityFactoryTestCase

[Darran Lofthouse (JIRA)]

Darran Lofthouse created WFCORE-3181:
----------------------------------------

             Summary: Review CustomCredentialSecurityFactoryTestCase
                 Key: WFCORE-3181
                 URL: https://issues.jboss.org/browse/WFCORE-3181
             Project: WildFly Core
          Issue Type: Bug
          Components: Security, Test Suite
            Reporter: Darran Lofthouse
             Fix For: 4.0.0.Alpha1


The test case CustomCredentialSecurityFactoryTestCase appears to be testing that the 'code does what it does' rather than testing the 'code is doing what it should'.

The test is testing a custom credential security factory can be called but the test is using HTTP Basic authentication and relying on SPNEGO authentication being triggered as this is the only mechanism that currently uses this factory.

Should a minor change be required to the SPNEGO authentication mechanism which affects when this credential factory is called this test case could subsequently fail.

If possible it would be better to convert this test to be a SPNEGO test and then test the behaviour of the credential security factory affects the mechanism as expected.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)