[ https://issues.jboss.org/browse/JGRP-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455908#comment-13455908 ]
Bela Ban commented on JGRP-2061:
--------------------------------
The code below passes:
{code:java}
String input="Bela Ban";
byte[] buf=Util.objectToByteBuffer(input);
String tmp=Util.objectFromByteBuffer(buf);
assert tmp.equals(input);
input="Béla Ban";
buf=Util.objectToByteBuffer(input);
tmp=Util.objectFromByteBuffer(buf);
assert tmp.equals(input);
{code}
> TYPE_STRING does not handle unicode
> -----------------------------------
>
> Key: JGRP-2061
> URL: https://issues.jboss.org/browse/JGRP-2061
> Project: JGroups
> Issue Type: Bug
> Reporter: Cody Ebberson
> Assignee: Bela Ban
> Fix For: 4.0.6
>
>
> In several places throughout the org.jgroups.util.Util class, it is assumed that Strings are one byte per character.
> For example, see objectToByteBuffer lines 561-567:
> https://github.com/belaban/JGroups/blob/master/src/org/jgroups/util/Util.java#L561-L567
> {code:java}
> case TYPE_STRING:
> String str=(String)obj;
> int len=str.length();
> ByteBuffer retval=ByteBuffer.allocate(Global.BYTE_SIZE + len).put(TYPE_STRING);
> for(int i=0; i < len; i++)
> retval.put((byte)str.charAt(i));
> return retval.array();
> {code}
> This code will incorrectly encode any String with non ASCII encoding.
> There are several options to fix. You could use str.getBytes(StandardCharsets.UTF_8) to get a proper byte encoding, or you could use the existing TYPE_SERIALIZABLE code path.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)