[jboss-jira] [JBoss JIRA] (WFCORE-3450) CLI - avoid required attributes to be hard to see when using tab completion

Jean-Francois Denise (JIRA) issues at jboss.org
Thu Dec 7 03:33:01 EST 2017


    [ https://issues.jboss.org/browse/WFCORE-3450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502781#comment-13502781 ] 

Jean-Francois Denise commented on WFCORE-3450:
----------------------------------------------

[~iweiss], you made a point related to documentation, we need to document that '*' means required. I will add a note in the cli help. This should have been done first place.
Coloured CLI would be something to discuss. As soon as we choose some colours, we would have people liking them and other not liking. Making colours configurable seems a bit too much to me. Colours are also not interpreted the same way on various platforms, so colouring should be adapted per platform. Personally I don't think that coloured terminal is helpful, I much prefer back and white. bold could be a good alternative for required attributes.

BTW, Aesh already supports that by the mean of ANSI. I remember that [~ehugonnet] did some prototyping to colour operation failure in red.





> CLI - avoid required attributes to be hard to see when using tab completion 
> ----------------------------------------------------------------------------
>
>                 Key: WFCORE-3450
>                 URL: https://issues.jboss.org/browse/WFCORE-3450
>             Project: WildFly Core
>          Issue Type: Feature Request
>          Components: CLI
>            Reporter: Miroslav Novak
>
> This is follow up for WFCORE-2283 which marked required attributes by "*" when using tab completion. Still if there are many attributes, it's hard to see all required attributes, for example in:
> {code}
> [standalone at localhost:9990 /] /subsystem=messaging-activemq/server=default/cluster-connection=my-cluster:add(
> !                              check-period                   connector-name*                max-retry-interval             notification-interval          retry-interval-multiplier
> allow-direct-connections-only  cluster-connection-address*    discovery-group*               message-load-balancing-type    producer-window-size           static-connectors*
> call-failover-timeout          confirmation-window-size       initial-connect-attempts       min-large-message-size         reconnect-attempts             use-duplicate-detection
> call-timeout                   connection-ttl                 max-hops                       notification-attempts          retry-interval  
> {code}
> it's not clear at the first look how many required attributes there are.
> Suggestion is to group required attributes together and then provide list of other attributes, for example on the next line. Another options might be considered as well. For example to show required attributes when double pressing <tab>.
> Discussed on https://developer.jboss.org/wiki/CLI-BetterCompletionForArguments?et=watches.email.document_comment#comment-16622 



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)


More information about the jboss-jira mailing list