[jboss-jira] [JBoss JIRA] (ELY-609) Unguarded read in ElytronPolicyConfiguration

[Jan Kalina (JIRA)]

    [ https://issues.jboss.org/browse/ELY-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503578#comment-13503578 ] 

Jan Kalina commented on ELY-609:
--------------------------------

I has go through it and it looks no synchronization is actually needed here - synchronized blocks need to protect state changes only, so adding *volatile* to create atomic reference will be sufficient.

> Unguarded read in ElytronPolicyConfiguration
> --------------------------------------------
>
>                 Key: ELY-609
>                 URL: https://issues.jboss.org/browse/ELY-609
>             Project: WildFly Elytron
>          Issue Type: Bug
>    Affects Versions: 1.1.0.Beta7
>            Reporter: Ondrej Lukas
>            Assignee: Jan Kalina
>              Labels: static_analysis
>             Fix For: 1.2.0.Beta12
>
>
> Access to fields {{uncheckedPermissions}}, {{excludedPermissions}} and {{rolePermissions}} in {{org.wildfly.security.authz.jacc.ElytronPolicyConfiguration}} is holded by lock. However lock is not used in their getter methods. Getters should be also handled by locks to avoid unguarded read of those fields.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)