[jboss-jira] [JBoss JIRA] (WFCORE-2298) RespawnHttpTestCase and RespawnTestCase don't account for recycling of PIDs

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13363521#comment-13363521 ] 

Brian Stansberry commented on WFCORE-2298:
------------------------------------------

This probably can't be made perfect (at least not with effort reasonable for the problem) but

1) RunningProcess.equals/hashCode can account for both the PID and the process "type" string.
2) Use that for checking if a process should be ignored, instead of just the PID, so if server-one reloads to the PID used before by server-two, it's not counted as not having reloaded.
3) Check more frequently, with no initial delay
4) Once an excluded process isn't seen, stop excluding it, so if it resurrects its not treated as the old process.

Also, RespawnTestCase and RespawnHttpTestCase should share the utility code here instead of duplicating it.

> RespawnHttpTestCase and RespawnTestCase don't account for recycling of PIDs
> ---------------------------------------------------------------------------
>
>                 Key: WFCORE-2298
>                 URL: https://issues.jboss.org/browse/WFCORE-2298
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management, Test Suite
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Minor
>
> On Windows, apparently PIDs can be recycled in such a way that they can reappear shortly after the first process with a PID is terminated. (See http://stackoverflow.com/questions/26301382/does-windows-7-recycle-process-id-pid-numbers/31257979#31257979 and links therein.)
> RespawnHttpTestCase is assuming that this won't happen, since when checking for reload completion it ignores any PID that belonged to one of the servers that's expected to be restarted. I'm seeing intermittent failures that seem to be due to this expectation being incorrect, as the logging for the failed tests clearly shows that the servers are restarted.
> For example:
> https://ci.wildfly.org/viewLog.html?buildId=45601&tab=buildResultsDiv&buildTypeId=WildFlyCore_PullRequestWindows



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)