[jboss-jira] [JBoss JIRA] (WFCORE-2073) Increase the likelihood of ManagedProcess kill invoking the OS kill command when multiple HCs are on the system

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13366597#comment-13366597 ] 

Brian Stansberry commented on WFCORE-2073:
------------------------------------------

https://github.com/wildfly/wildfly-core/compare/master...bstansberry:WFCORE-2073

> Increase the likelihood of ManagedProcess kill invoking the OS kill command when multiple HCs are on the system
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-2073
>                 URL: https://issues.jboss.org/browse/WFCORE-2073
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>            Priority: Minor
>
> The ManagedProcess kill() method relies on a scan of running processes that have a command line with -D[<processname>] in the command line, refusing to do the OS kill if > 1 such process is found.
> This is troublesome if you have > 1 HC on the machine, as they are likely to use the same process names (e.g. "Server:server-one"). So the 'kill' doesn't happen, and destroy() gets used instead. Destroy doesn't seem as strong, as it seems to not prevent shutdown hook execution, leaving open the possibility of hangs.
> Perhaps the PC could generate a random int or even a short and include that as a param on the command line as well, then use that as part of the discrimination check.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)