[jboss-jira] [JBoss JIRA] (WFLY-5966) Validate requirement for modules previously exported by javax.ejb.api

[Martin Kouba (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13369445#comment-13369445 ] 

Martin Kouba commented on WFLY-5966:
------------------------------------

It should be safe to remove the depndencies from the {{org.jboss.weld.core}} module (feature-pack/src/main/resources/modules/system/layers/base/org/jboss/weld/core/main/module.xml). Weld subsystem module.xml does not contain the dependencies any more.

Note that this "blind addition" significantly affects the size of  WildFly Swarm uberjar because {{org.omg.api}} depends on {{org.jboss.jts}} -> {{org.apache.activemq.artemis}} -> {{org.wildfly.extension.messaging-activemq}} -> {{org.jboss.as.weld}} etc etc.. So once you add any of the modules mentioned above the size grows significantly (brings EJB3, Hibernate, etc.).

> Validate requirement for modules previously exported by javax.ejb.api
> ---------------------------------------------------------------------
>
>                 Key: WFLY-5966
>                 URL: https://issues.jboss.org/browse/WFLY-5966
>             Project: WildFly
>          Issue Type: Task
>          Components: Server
>            Reporter: Brian Stansberry
>            Assignee: Jason Greene
>
> The WFLY-5922 fix removed the exporting of a number of modules from javax.ejb.api. That introduced some problems with modules that depended on those exported packages no longer having visibility to needed classes, so to prevent problems I blindly added a commit to the module.xml for each module that depended upon javax.ejb.api to add a dependency set like this:
> {code}
>         <!-- TODO validate the need for these and remove if not needed.
>              Prior to WFLY-5922 they were exported by javax.ejb.api. -->
>         <module name="javax.api"/>
>         <module name="javax.transaction.api"/>
>         <module name="javax.xml.rpc.api"/>
>         <module name="javax.rmi.api"/>
>         <module name="org.omg.api"/>
> {code}
> If a module already had a dep on one of those, it's not in the block.
> This task is to check each of these modules and replace that block with normal dependency declarations for any that are truly needed.
> Affected modules:
> feature-pack/src/main/resources/modules/system/layers/base/javaee/api/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/javax/management/j2ee/api/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/ejb3/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jpa/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jpa/spi/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/jsr77/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/webservices/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/weld/main/module.xml        
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/as/xts/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/ejb-client/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/ejb3/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/iiop-client/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/metadata/appclient/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/metadata/ejb/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/narayana/compensations/main/module.xml        
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/narayana/rts/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/narayana/txframework/main/module.xml        
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/weld/core/main/module.xml        
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/ws/common/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jboss/xts/main/module.xml        
> feature-pack/src/main/resources/modules/system/layers/base/org/wildfly/extension/rts/main/module.xml
> The following modules were indirectly affected via their dependency on javaee.api, which in turn exports javax.ejb.api:
> feature-pack/src/main/resources/modules/system/layers/base/com/sun/jsf-impl/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/jberet/jberet-core/main/module.xml
> feature-pack/src/main/resources/modules/system/layers/base/org/wildfly/jberet/main/module.xml
> jsf/multi-jsf-installer/src/main/resources/mojarra-impl-module.xml
> jsf/multi-jsf-installer/src/main/resources/myfaces-impl-module.xml
>  



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)