[jboss-jira] [JBoss JIRA] (WFCORE-1752) The deployment-overlay command fails to redeploy affected deployments

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13347544#comment-13347544 ] 

Brian Stansberry commented on WFCORE-1752:
------------------------------------------

I don't have a good answer, just wanted to comment on this:

"I am trying to keep the --deployments option to reference deployment names and do the conversion to the runtime name internally when needed (mainly when adding the deployment to the overlay). The deployment name seems to me what people are really using to reference deployment (If I am wrong just say it). "

The meaning of this CLI parameter needs to align with the meaning of what is stored in the server side model and persisted. If they have 2 wars foo-1.war and foo-2.war installed, both with runtime name foo.war, and they say --deployments=foo-1.war they are going to actually be affecting both deployments.
 
I think having the server side model use runtime-name was a mistake, but we are kind of stuck with it.

Can execution of redeploy-affected be moved to the server side? The server will have all the data (including deployments added/removed in the batch) by the time it needs to do any changes to the service container.


> The deployment-overlay command fails to redeploy affected deployments
> ---------------------------------------------------------------------
>
>                 Key: WFCORE-1752
>                 URL: https://issues.jboss.org/browse/WFCORE-1752
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.0.0.Alpha5
>            Reporter: ehsavoie Hugonnet
>            Assignee: Jean-Francois Denise
>
> The deployment-overlay command fails to redeploy affected deployments if the runtime-name isn't the same as the deployment name. Since affected deployment to be redeployed should be running the couple runtime-name + enabled == true should be used to define which deployments are affected instead of using the deployment name since the name used in overlay is the runtime-name



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)