[jboss-jira] [JBoss JIRA] (WFLY-7966) Coverity static analysis: Suspicious integer expression in BSDUnixDESCryptPasswordImpl (Elytron)

[Martin Choma (JIRA)]

     [ https://issues.jboss.org/browse/WFLY-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Choma updated WFLY-7966:
-------------------------------
    Affects Version/s: 11.0.0.Alpha1


> Coverity static analysis: Suspicious integer expression in BSDUnixDESCryptPasswordImpl (Elytron)
> ------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-7966
>                 URL: https://issues.jboss.org/browse/WFLY-7966
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>    Affects Versions: 11.0.0.Alpha1
>            Reporter: Martin Choma
>            Assignee: Darran Lofthouse
>
> Seems {{if}} statement will never be {{true}}, because invKeyPerm is of type byte[]. And permitted values for byte are -128...127. 
> {code:java|title=BSDUnixDESCryptPasswordImpl.java}
> outBit = invKeyPerm[inBit];
> if (outBit == 255) {
>     continue;
> }
> {code}
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=8553812&defectInstanceId=2138962&mergedDefectId=1377479&fileStart=1&fileEnd=250



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)