[jboss-jira] [JBoss JIRA] (WFLY-7483) Credential store has configuration in "uri" attribute.

[Martin Choma (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13353537#comment-13353537 ] 

Martin Choma commented on WFLY-7483:
------------------------------------

As far as I can tell, uri attribute has no external meaning. Attribute uri is introduced by subsystem. Elytron itself works with Map. Actually attribute name "uri" looks to me confusing. I don't see clear connection with credential-store topic. Renaming to "properties" would make more sense to me. With string approach I just see cons with escaping delimiters ('?', ';'). And from user experience point of view it is just another solution for generic key/value pairs.

> Credential store has configuration in "uri" attribute.
> ------------------------------------------------------
>
>                 Key: WFLY-7483
>                 URL: https://issues.jboss.org/browse/WFLY-7483
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>            Reporter: Hynek Švábek
>            Assignee: Peter Skopek
>            Priority: Critical
>
> Credential store has configuration in "uri" attribute. All parameters are in one string. It can be confusing and there is risk of typo (e.g. delimiter typo)
> In my opinion the main intention for it is to have general solution for custom implementation.
> *Current state*
> {code}
> /subsystem=elytron/credential-store=cs001:add(uri="cr-store://test/cs/keystore.jceks?store.password=pass123;create.storage=true")
> {code}
> *Suggestion for improvement:*
> Better solution to achieve this could be use a map.
> e.g. some like that:
> {code}
> /subsystem=elytron/credential-store=credStore:add(cs-map={store.password=pass123, create.storage=true, store.file=path/to/cred/file})
> {code}
> Now credential store name is in URI too, it can be get from resource name.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)