[jboss-jira] [JBoss JIRA] (WFLY-7483) Credential store has configuration in "uri" attribute.

[Brad Maxwell (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13353628#comment-13353628 ] 

Brad Maxwell commented on WFLY-7483:
------------------------------------

It seems like if any or all of these configurations (cr-store-path, store.password,create.storage) are common and will be set for every credential store, then it would make more sense that they be separate parameters and then for any generic properties handled like a list of key value pairs. Similar to like datasource subsystem, this URI form reminds me of a datasource string with everything listed in it, where we split those up in the datasource subsystem instead of using 1 string

> Credential store has configuration in "uri" attribute.
> ------------------------------------------------------
>
>                 Key: WFLY-7483
>                 URL: https://issues.jboss.org/browse/WFLY-7483
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>            Reporter: Hynek Švábek
>            Assignee: Peter Skopek
>            Priority: Critical
>
> Credential store has configuration in "uri" attribute. All parameters are in one string. It can be confusing and there is risk of typo (e.g. delimiter typo)
> In my opinion the main intention for it is to have general solution for custom implementation.
> *Current state*
> {code}
> /subsystem=elytron/credential-store=cs001:add(uri="cr-store://test/cs/keystore.jceks?store.password=pass123;create.storage=true")
> {code}
> *Suggestion for improvement:*
> Better solution to achieve this could be use a map.
> e.g. some like that:
> {code}
> /subsystem=elytron/credential-store=credStore:add(cs-map={store.password=pass123, create.storage=true, store.file=path/to/cred/file})
> {code}
> Now credential store name is in URI too, it can be get from resource name.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)