[jboss-jira] [JBoss JIRA] (DROOLS-1653) Unused method parameter "alphaNodeHashingThreshold" in CompositeObjectSinkAdapter

[Mario Fusco (JIRA)]

     [ https://issues.jboss.org/browse/DROOLS-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mario Fusco resolved DROOLS-1653.
---------------------------------
    Resolution: Rejected


The addObjectSink method in CompositeObjectSinkAdapter has that alphaNodeHashingThreshold argument only because the method signature is declared in that way in the ObjectSinkPropagator interface. The argument is required by other implementations of that interface.

> Unused method parameter "alphaNodeHashingThreshold" in CompositeObjectSinkAdapter
> ---------------------------------------------------------------------------------
>
>                 Key: DROOLS-1653
>                 URL: https://issues.jboss.org/browse/DROOLS-1653
>             Project: Drools
>          Issue Type: Bug
>          Components: core engine
>    Affects Versions: 7.1.0.Beta3
>            Reporter: Tibor Zimányi
>            Assignee: Mario Fusco
>            Priority: Minor
>              Labels: reported-by-qe
>
> There is a suspicious unused method attribute "alphaNodeHashingThreshold" in CompositeObjectSinkAdapter. See this [1]. It can be a potential bug, because as you can see in the previous method in the class, the method is called with "0" as a parameter value for this.
> [1] https://github.com/kiegroup/drools/blob/38b68002a9cff5aeada9420cf87362a7b1213900/drools-core/src/main/java/org/drools/core/reteoo/CompositeObjectSinkAdapter.java#L104



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)