[jboss-jira] [JBoss JIRA] (WFLY-9076) Make the IIOP migration warnings more user friendly

[Tomasz Adamski (JIRA)]

     [ https://issues.jboss.org/browse/WFLY-9076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tomasz Adamski updated WFLY-9076:
---------------------------------
    Description: 
JBEAP-10124 changed the behaviour of jacorb:migrate operation to print migration warnings instead of throwing an error in case inconsistent configuration was used. We should update the warning messages to more user friendly form as now it may not be totally clear for user what is expected of him to do.

*reproduce*
Add the following snippet into EAP7.1 standalone.xml configuration
{code:xml}
<extension module="org.jboss.as.jacorb"/>
...
<subsystem xmlns="urn:jboss:domain:jacorb:1.4">
    <orb socket-binding="jacorb" ssl-socket-binding="jacorb-ssl">
        <initializers security="identity" transactions="on"/>
    </orb>
    <security client-supports="ServerAuth" client-requires="ServerAuth" server-supports="ServerAuth" server-requires="ServerAuth"/>
    <ior-settings>
        <transport-config integrity="required" confidentiality="supported" trust-in-client="required" trust-in-target="supported"
            detect-replay="required" detect-misordering="required"/>
        <as-context auth-method="none" realm="ApplicationRealm" required="true"/>
        <sas-context caller-propagation="supported"/>
    </ior-settings>
</subsystem>
{code}
run the following command from $JBOSS_HOME/bin directory
{noformat}
[pkremens at localhost bin] $ ./jboss-cli.sh 'embed-server, /subsystem=jacorb:describe-migration' | grep --after-context=7 migration-warnings
{noformat}

*actual*
{noformat}
        "migration-warnings" => [
            "WFLYIIOP0111: SSL has not been configured but ssl-port property has been specified - the connection will use clear-text protocol",
            "WFLYIIOP0105: Inconsistent transport-config configuration: integrity is not supported but it is not configured with NONE value",
            "WFLYIIOP0105: Inconsistent transport-config configuration: confidentiality is not supported but it is not configured with NONE value",
            "WFLYIIOP0105: Inconsistent transport-config configuration: trust-in-client is not supported but it is not configured with NONE value",
            "WFLYIIOP0104: Inconsistent transport-config configuration: detect-misordering is supported but it is configured with NONE value",
            "WFLYIIOP0104: Inconsistent transport-config configuration: detect-replay is supported but it is configured with NONE value"
        ]
{noformat}
*expected*
Warning messages clearly states what is expected from user to make the configuration valid.
{noformat}
...
            "WFLYIIOP0105: Inconsistent transport-config configuration: trust-in-client is not supported, please remove it or configure it to NONE value",
...
{noformat}

cc: [~dsimko], [~ochaloup]


> Make the IIOP migration warnings more user friendly
> ---------------------------------------------------
>
>                 Key: WFLY-9076
>                 URL: https://issues.jboss.org/browse/WFLY-9076
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: IIOP
>    Affects Versions: 11.0.0.Alpha1
>            Reporter: Tomasz Adamski
>            Assignee: Tomasz Adamski
>             Fix For: 11.0.0.Beta1
>
>
> JBEAP-10124 changed the behaviour of jacorb:migrate operation to print migration warnings instead of throwing an error in case inconsistent configuration was used. We should update the warning messages to more user friendly form as now it may not be totally clear for user what is expected of him to do.
> *reproduce*
> Add the following snippet into EAP7.1 standalone.xml configuration
> {code:xml}
> <extension module="org.jboss.as.jacorb"/>
> ...
> <subsystem xmlns="urn:jboss:domain:jacorb:1.4">
>     <orb socket-binding="jacorb" ssl-socket-binding="jacorb-ssl">
>         <initializers security="identity" transactions="on"/>
>     </orb>
>     <security client-supports="ServerAuth" client-requires="ServerAuth" server-supports="ServerAuth" server-requires="ServerAuth"/>
>     <ior-settings>
>         <transport-config integrity="required" confidentiality="supported" trust-in-client="required" trust-in-target="supported"
>             detect-replay="required" detect-misordering="required"/>
>         <as-context auth-method="none" realm="ApplicationRealm" required="true"/>
>         <sas-context caller-propagation="supported"/>
>     </ior-settings>
> </subsystem>
> {code}
> run the following command from $JBOSS_HOME/bin directory
> {noformat}
> [pkremens at localhost bin] $ ./jboss-cli.sh 'embed-server, /subsystem=jacorb:describe-migration' | grep --after-context=7 migration-warnings
> {noformat}
> *actual*
> {noformat}
>         "migration-warnings" => [
>             "WFLYIIOP0111: SSL has not been configured but ssl-port property has been specified - the connection will use clear-text protocol",
>             "WFLYIIOP0105: Inconsistent transport-config configuration: integrity is not supported but it is not configured with NONE value",
>             "WFLYIIOP0105: Inconsistent transport-config configuration: confidentiality is not supported but it is not configured with NONE value",
>             "WFLYIIOP0105: Inconsistent transport-config configuration: trust-in-client is not supported but it is not configured with NONE value",
>             "WFLYIIOP0104: Inconsistent transport-config configuration: detect-misordering is supported but it is configured with NONE value",
>             "WFLYIIOP0104: Inconsistent transport-config configuration: detect-replay is supported but it is configured with NONE value"
>         ]
> {noformat}
> *expected*
> Warning messages clearly states what is expected from user to make the configuration valid.
> {noformat}
> ...
>             "WFLYIIOP0105: Inconsistent transport-config configuration: trust-in-client is not supported, please remove it or configure it to NONE value",
> ...
> {noformat}
> cc: [~dsimko], [~ochaloup]



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)