[jboss-jira] [JBoss JIRA] (WFCORE-3090) Make script messages around process restarts consistent

Brian Stansberry (JIRA) issues at jboss.org
Fri Jul 21 10:53:00 EDT 2017


    [ https://issues.jboss.org/browse/WFCORE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438877#comment-13438877 ] 

Brian Stansberry commented on WFCORE-3090:
------------------------------------------

https://github.com/wildfly/wildfly-core/pull/2631 is what triggered me to file this -- it brings the ps1 behavior to bat.

> Make script messages around process restarts consistent
> -------------------------------------------------------
>
>                 Key: WFCORE-3090
>                 URL: https://issues.jboss.org/browse/WFCORE-3090
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Scripts
>            Reporter: Brian Stansberry
>            Assignee: Tomaz Cerar
>            Priority: Minor
>
> The message we output when a process is restarted is inconsistent:
> standalone.sh "Restarting application server..."
> domain.sh "Restarting JBoss..."
> standalone.ps1 "Restarting application server..." (from common.ps1)
> domain.ps1 "Restarting application server..." (from common.ps1)
> standalone.bat nothing
> domain.bat nothing
> Problems:
> 1) domain.ps1 is inaccurate as it's not just an application server being restarted
> 2) The bat files are inconsistent with the others
> 3) domain.sh's "Restarting JBoss..." is a bit vague and is odd theoretically given that WildFly Core is meant to be usable for all sorts of things that may not be regarded as "JBoss".
> Perhaps just KISS "Restarting..." in all cases? If we want to keep "application server" for the standalone.xxx cases then common.ps1's function will need to have a param added, and then we need to decide a meaningful value for that param (empty text being a valid choice.)



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jboss-jira mailing list