[jboss-jira] [JBoss JIRA] (JGRP-2205) DISCARD ignores the DONT_LOOPBACK transient flag

[Dan Berindei (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439463#comment-13439463 ] 

Dan Berindei commented on JGRP-2205:
------------------------------------

No, would only change {{down(Message)}} to clarify what {{DISCARD}} is supposed to do when {{discard_all == true && excludeItself == true}}. I would instead change {{loopback(Message)}} to something like this:

{code}
        final Message rsp=msg.copy(true);
        if(rsp.getSrc() == null)
            rsp.setSrc(localAddress());
        
        rsp.dest(localAddress());
        down(rsp);
{code}

> DISCARD ignores the DONT_LOOPBACK transient flag
> ------------------------------------------------
>
>                 Key: JGRP-2205
>                 URL: https://issues.jboss.org/browse/JGRP-2205
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 4.0.4
>            Reporter: Dan Berindei
>            Assignee: Bela Ban
>             Fix For: 4.0.5
>
>
> When {{discard_all = true}}, {{DISCARD}} does its own loopback, and doesn't check for {{DONT_LOOPBACK}} like {{TP}}. It always sends the message back up, even if {{excludeItself = false}}.
> If possible, {{DISCARD}} should just set the message destination to the local address and pass the message down. That way, {{TP}} would decide make the loopback decision, and using the {{TP}} thread pool would also make the thread name nicer in the logs. (Currently the thread name is {{Thread-n}}, which means searching for the test name in our test suite's log misses some messages.)



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)