[jboss-jira] [JBoss JIRA] (DROOLS-1683) ExcelParse can re-write files

[James Livingston (JIRA)]

James Livingston created DROOLS-1683:
----------------------------------------

             Summary: ExcelParse can re-write files
                 Key: DROOLS-1683
                 URL: https://issues.jboss.org/browse/DROOLS-1683
             Project: Drools
          Issue Type: Bug
          Components: decision tables
    Affects Versions: 7.0.0.Final
            Reporter: James Livingston
            Assignee: Mario Fusco


ExcelParser.open(File) uses the single argument WorkbookFactory.create() call, which opens the file in rewad-write mode, so when parseWorkbook() calls close on it, it will save the workbook to disk.

Usually the resulting file is the same, however it may be binary-different but equivalent(causing git conflicts). Being read-only does not cause an error since the exceptions are swallowed silently.

It should use the three argument form of WorkbookFactory.create() and pass the read-only flag



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)