[jboss-jira] [JBoss JIRA] (WFLY-8456) Protocols added to a fork of some channel won't show in JMX MBeans

[Paul Ferraro (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13441772#comment-13441772 ] 

Paul Ferraro commented on WFLY-8456:
------------------------------------

I would suggest moving the mbean registration logic from ChannelBuilder to the ChannelFactory implementations themselves.  This eliminates the need for special handling for externally created channels.  Something like:
{code:java}
public MyChannelFactory implements ChannelFactoy, ChannelListener {
    @Override
    public Channel createChannel(String id) {
        Channel channel = // create channel
        JmxConfigurator.registerChannel(channel, ...);
        channel.addListener(this);
        return channel;
    }

    @Override
    public void channelClosed(Channel channel) { 
        JmxConfigurator.unregisterChannel(channel, ...);
        channel.removeListener(this);
    }
}
{code}

> Protocols added to a fork of some channel won't show in JMX MBeans
> ------------------------------------------------------------------
>
>                 Key: WFLY-8456
>                 URL: https://issues.jboss.org/browse/WFLY-8456
>             Project: WildFly
>          Issue Type: Bug
>          Components: Clustering
>    Affects Versions: 11.0.0.Alpha1
>            Reporter: Radoslav Husar
>            Assignee: Radoslav Husar
>            Priority: Optional
>
> When defining a fork of some channel and adding a protocol to the protocol stack of that fork channel, the newly added protocol won't show up in JMX MBeans.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)