[jboss-jira] [JBoss JIRA] (WFCORE-2895) Save memory in RuntimeCapability ServiceName creation

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415122#comment-13415122 ] 

Brian Stansberry commented on WFCORE-2895:
------------------------------------------

A note for the record: we'll probably do some more on this basic topic. Even with this I'm still seeing more ServiceName creations than I like, and I expect it's related to capabilities but I'm not sure quite how. I see stuff to improve but not how those things would equate to the "excess" number of names.

For example, even with this fix, a heap comparison of a standalone-full-ha.xml server vs EAP 7.0 shows 31 more ServiceControllerImpl instances but 2,433 more ServiceName instances.

Places to improve: CapabilityServiceSupportImpl.getCapabilityServiceName and OperationContextImpl.getCapabilityServiceName. The latter expect to have little impact as it should only be creating a new ServiceName in an edge case scenario.

> Save memory in RuntimeCapability ServiceName creation
> -----------------------------------------------------
>
>                 Key: WFCORE-2895
>                 URL: https://issues.jboss.org/browse/WFCORE-2895
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: 3.0.0.Beta24
>
>
> RuntimeCapability.fromBaseCapability results in a new RuntimeCapability that creates its ServiceName by parsing the base capability's string name instead of using its existing ServiceName. This wastes memory since the strings end up being duplicated.
> Also RuntimeCapability should not create a ServiceName if the cap has no serviceValueType.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)