[jboss-jira] [JBoss JIRA] (ELY-1150) Revisit branches in handleOne method in ServerAuthenticationContext.createCallbackHandler()

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/ELY-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415909#comment-13415909 ] 

David Lloyd commented on ELY-1150:
----------------------------------

EvidenceVerifyCallback and MechanismInformationCallback are definitely wrong and should have {{handleOne(callbacks, idx + 1)}} at their end.

The other problem branch is {{CachedIdentityAuthorizeCallback}} which looks completely wrong.  [~pcraveiro] could you take a look?


> Revisit branches in handleOne method in ServerAuthenticationContext.createCallbackHandler()
> -------------------------------------------------------------------------------------------
>
>                 Key: ELY-1150
>                 URL: https://issues.jboss.org/browse/ELY-1150
>             Project: WildFly Elytron
>          Issue Type: Bug
>    Affects Versions: 1.1.0.Beta38
>            Reporter: Ondrej Lukas
>            Assignee: Darran Lofthouse
>
> Three branches (for EvidenceVerifyCallback, MechanismInformationCallback, CredentialUpdateCallback) in {{handleOne}} method of CallbackHandler created in {{ServerAuthenticationContext.createCallbackHandler()}} do not call {{handleOne(callbacks, idx + 1);}}, which means that another callbacks in array are not processed then. In case it is expected then some assertion that no another callback is obtained in {{callbacks}} array should be added.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)