[jboss-jira] [JBoss JIRA] (ELY-1233) Elytron revise why exception stacktrace is not logged in some cases

[Martin Choma (JIRA)]

Martin Choma created ELY-1233:
---------------------------------

             Summary: Elytron revise why exception stacktrace is not logged in some cases
                 Key: ELY-1233
                 URL: https://issues.jboss.org/browse/ELY-1233
             Project: WildFly Elytron
          Issue Type: Bug
            Reporter: Martin Choma
            Assignee: Darran Lofthouse
            Priority: Critical


During verification of JBEAP-9297 I have found another occurences where logging should be justified. 
In some cases not logging exception can hide original cause of problem.

But justification is necessary if extending loggin won't introduce unnecessary logs, but it does not seems to me this should be case.

{code}
[mchoma at localhost wildfly-elytron]$ grep -r ".*\.debug([^\"]" --include=*.java .
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                            ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java:                                    ElytronMessages.log.debug(e);
./src/main/java/org/wildfly/security/http/util/SecurityProviderServerMechanismFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/http/util/SecurityProviderServerMechanismFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/http/util/ServiceLoaderServerMechanismFactory.java:                log.debug(e);
./src/main/java/org/wildfly/security/http/util/ServiceLoaderServerMechanismFactory.java:                log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslClientFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslClientFactory.java:                            log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslServerFactory.java:                                log.debug(e);
./src/main/java/org/wildfly/security/sasl/util/SecurityProviderSaslServerFactory.java:                            log.debug(e);

[mchoma at localhost wildfly-elytron]$ grep -r ".*\.trace([^\"]" --include=*.java .
./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:            ElytronMessages.tls.trace(b);
./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:                    ElytronMessages.tls.trace(b);
./src/main/java/org/wildfly/security/http/impl/DigestAuthenticationMechanism.java:                        log.trace(e);
{code}

These are OK
{code}
./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:            ElytronMessages.tls.trace(b);
./src/main/java/org/wildfly/security/ssl/CipherSuiteSelector.java:                    ElytronMessages.tls.trace(b);
{code}

Setting to Critical priority, as this could reveal useful information during process of troubleshooting.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)