[jboss-jira] [JBoss JIRA] (WFLY-8925) Mark attribute 'outbound-socket-binding' in a reverse-proxy handler as 'required'

[Romain Pelisse (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-8925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420534#comment-13420534 ] 

Romain Pelisse commented on WFLY-8925:
--------------------------------------

FYI, here is the new behavior, with my proposed change:



{code:java}
[standalone at localhost:9990 /] /subsystem=undertow/configuration=handler/reverse-proxy=my-rev-proxy/host=some-host:add(outbound-socket-binding=mail-smtp)
{"outcome" => "success"}
[standalone at localhost:9990 /] /subsystem=undertow/configuration=handler/reverse-proxy=my-rev-proxy/host=some-host2:add()
{
    "outcome" => "failed",
    "failure-description" => "WFLYCTL0155: 'outbound-socket-binding' may not be null",
    "rolled-back" => true
}
{code}


_Note: Obviously, using the mail-stmp as outbound-socket-binding makes no sense - but as it is the only defined by default, it is test out of the box._

> Mark attribute 'outbound-socket-binding' in a reverse-proxy handler as 'required'
> ---------------------------------------------------------------------------------
>
>                 Key: WFLY-8925
>                 URL: https://issues.jboss.org/browse/WFLY-8925
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 11.0.0.Alpha1
>            Reporter: Romain Pelisse
>            Assignee: Romain Pelisse
>            Priority: Minor
>
> {{outbound-socket-binding}} attribute in {{/subsystem=undertow/configuration=handler/reverse-proxy=my-rev-proxy/host=some-host}} is not marked as '{{required}}'. Please mark it as required as if {{outbound-socket-binding}} is not specified during 'add' operation, it fails with:
> {code}
> /subsystem=undertow/configuration=handler/reverse-proxy=my-rev-proxy/host=some-host:add()
> {
>     "outcome" => "failed",
>     "failure-description" => {
>         "WFLYCTL0412: Required services that are not installed:" => ["org.wildfly.network.outbound-socket-binding.undefined"],
>         "WFLYCTL0180: Services with missing/unavailable dependencies" => ["org.wildfly.undertow.reverse-proxy.host.my-rev-proxy.some-host is missing [org.wildfly.network.outbound-socket-binding.undefined]"]
>     },
>     "rolled-back" => true
> }
> {code}
> I suppose when this attribute is marked as required, more pleasant failure message is given.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)