[jboss-jira] [JBoss JIRA] (WFCORE-2517) Coverity, Dereference after null check (Elytron subsystem)

[Martin Choma (JIRA)]

Martin Choma created WFCORE-2517:
------------------------------------

             Summary: Coverity, Dereference after null check (Elytron subsystem)
                 Key: WFCORE-2517
                 URL: https://issues.jboss.org/browse/WFCORE-2517
             Project: WildFly Core
          Issue Type: Bug
          Components: Security
            Reporter: Martin Choma
            Assignee: Darran Lofthouse


Coverity found possible dereference of null. In this code {{defaultPolicy}} is checked for null and in next step {{defaultPolicy.equals()}} is called.

https://scan7.coverity.com/reports.htm#v23632/p12663/fileInstanceId=10578397&defectInstanceId=2572005&mergedDefectId=1407435

{code:java|title=PolicyParser.java}
        boolean providerFound = defaultPolicy == null;

        while (reader.hasNext() && reader.nextTag() != END_ELEMENT) {
            verifyNamespace(reader);
            String localName = reader.getLocalName();
            switch (localName) {
                // Permission Mapper
                case JACC_POLICY:
                    providerFound = defaultPolicy.equals(parseJaccPolicy(addPolicy, reader, operations)) || providerFound;
                    break;
                case CUSTOM_POLICY:
                    providerFound = defaultPolicy.equals(parseCustomPolicy(addPolicy, reader, operations)) || providerFound;
                    break;
                default:
                    throw unexpectedElement(reader);
            }
        }
{code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)