[jboss-jira] [JBoss JIRA] (WFCORE-1762) Missing dependency should be triggering rollback of the deployment operation

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13380506#comment-13380506 ] 

Brian Stansberry commented on WFCORE-1762:
------------------------------------------

The specific problem here is the no-longer-available service is not one that was directly removed by the management op. Instead it's a child service of the one the op removed (a great-great-great grandchild really). The result of that is the OperationContext doesn't know how to associate the missing dependency with the step that caused the problem.

I don't know how to make that association. If the problem op is a step in a composite it's not possible to identify the specific step in the composite that broke things.

But it's possible to detect that the overall op has triggered a missing dependency and that no step has been reported as problematic. If that happens, a failure message can be associated with the main operation response. If its a composite the particular step won't get the failure description, but the overall op will and hopefully the user can figure out the problem step.

This kind of thing mostly can happen when something outside a deployment depends on a service created when the deployment is deployed. So, inter-deployment dependencies, or like here a container service depending on a deployment service. The management op knows about root deployment service. But it's a great-great-great grandchild of that root deployment service that becomes the missing dependency.

> Missing dependency should be triggering rollback of the deployment operation
> ----------------------------------------------------------------------------
>
>                 Key: WFCORE-1762
>                 URL: https://issues.jboss.org/browse/WFCORE-1762
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 3.0.0.Alpha7
>            Reporter: Martin Stefanko
>
> The removal of the deployment which is a dependency for other resources makes these dependent resources unusable. The deployment operation should not be completed in such conditions.
> The information about the missing dependencies is now currently logged after the removal by the ContainerStateMonitor class.
> Example:
> {code}INFO  [org.jboss.as.server.deployment] (MSC service thread 1-6) WFLYSRV0028: Stopped deployment postgresql-9.4.1208.jar (runtime-name: postgresql-9.4.1208.jar) in 61ms
> INFO  [org.jboss.as.server] (ServerService Thread Pool -- 65) WFLYSRV0009: Undeployed "postgresql-9.4.1208.jar" (runtime-name: "postgresql-9.4.1208.jar")
> INFO  [org.jboss.as.repository] (ServerService Thread Pool -- 65) WFLYDR0002: Content removed from location /home/mjurc/testing/eap/7.0.0/jboss-eap-7.0/standalone/data/content/5c/7e80698b80a5045fe64daa67426051bbd16a56/content
> INFO  [org.jboss.as.controller] (ServerService Thread Pool -- 65) WFLYCTL0183: Service status report
> WFLYCTL0184:    New missing/unsatisfied dependencies:
>       service jboss.jdbc-driver.postgresql-9_4_1208_jar (missing) dependents: [service jboss.driver-demander.java:/PostgresDS, service org.wildfly.data-source.PostgresDS] 
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)