[jboss-jira] [JBoss JIRA] (WFCORE-2351) There stuck some required service after unsuccessful command for adding CredentialStore with wrong filled relative-to attribute.

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13380528#comment-13380528 ] 

Brian Stansberry commented on WFCORE-2351:
------------------------------------------

WFCORE-1762 relates to my most recent comment on WFCORE-2351 as the WFCORE-1762 change will ensure that an ERROR is logged if an op introduces MSC failures or missing services and none of the other op verification techniques detect that. One of the benefits of the current ContainerStateMonitor INFO level logging is it would at least produce some output in that kind of situation, but that benefit would now be covered in a better way by WFCORE-1762.

That makes me comfortable with having the ContainerStateMonitor INFO level logging only log the final status at the end of the op, after any rollback work. Which means in most cases no logging at all.

With that I also think the ContainerStateMonitor should be a WARN if the report shows any problems, and INFO otherwise. If the final result of the op is MSC is left with installed services that failed or having missing dependencies, that should be a WARN.

> There stuck some required service after unsuccessful command for adding CredentialStore with wrong filled relative-to attribute.
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-2351
>                 URL: https://issues.jboss.org/browse/WFCORE-2351
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>            Reporter: Hynek Švábek
>            Assignee: Brian Stansberry
>
> There stuck some required service after unsuccessful command for adding CredentialStore with wrong filled relative-to attribute.
> *Command with wrong filled relative-to attribute* 
> {code}
> /subsystem=elytron/credential-store=CredStore108:add(uri="cr-store://test/cs108.jceks?create.storage=true",  credential-reference={clear-text=pass123}, relative-to=non.exist.path.resource)
> {code}
> *You can see this log.*
> Especially information about New missing/unsatisfied dependencies:is important and it wouldn't be there.
> {code}
> 16:54:18,809 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 8) WFLYCTL0013: Operation ("add") failed - address: ([
>     ("subsystem" => "elytron"),
>     ("credential-store" => "CredStore108")
> ]) - failure description: {
>     "WFLYCTL0412: Required services that are not installed:" => ["jboss.server.path.\"non.exist.path.resource\""],
>     "WFLYCTL0180: Services with missing/unavailable dependencies" => ["org.wildfly.security.credential-store.CredStore108 is missing [jboss.server.path.\"non.exist.path.resource\"]"]
> }
> 16:54:18,810 INFO  [org.jboss.as.controller] (management-handler-thread - 8) WFLYCTL0183: Service status report
> WFLYCTL0184:    New missing/unsatisfied dependencies:
>       service jboss.server.path."non.exist.path.resource" (missing) dependents: [service org.wildfly.security.credential-store.CredStore108] 
> {code}
> *Now we try process same command without relative-to attribute*
> {code}
> /subsystem=elytron/credential-store=CredStore108:add(uri="cr-store://test/cs108.jceks?create.storage=true",  credential-reference={clear-text=pass123})   
> {code}
> *Result is success but we can notice this in log:*
> {code}
> 16:55:33,093 INFO  [org.jboss.as.controller] (management-handler-thread - 10) WFLYCTL0183: Service status report
> WFLYCTL0185:    Newly corrected services:
>       service jboss.server.path."non.exist.path.resource" (no longer required)
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)