[jboss-jira] [JBoss JIRA] (WFCORE-2351) There stuck some required service after unsuccessful command for adding CredentialStore with wrong filled relative-to attribute.

[Chao Wang (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13380697#comment-13380697 ] 

Chao Wang commented on WFCORE-2351:
-----------------------------------

Thank your for all the detailed analysis above. In your change, you checked the controller state is not REMOVED before adding any missing dependency. But there are other states like STOPPING and START_FAILED, I guess they are not considered as reasonable state in this particular missing dependency lookup, it's thus safe to only compare with REMOVED here?

> There stuck some required service after unsuccessful command for adding CredentialStore with wrong filled relative-to attribute.
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-2351
>                 URL: https://issues.jboss.org/browse/WFCORE-2351
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>            Reporter: Hynek Švábek
>            Assignee: Brian Stansberry
>
> There stuck some required service after unsuccessful command for adding CredentialStore with wrong filled relative-to attribute.
> *Command with wrong filled relative-to attribute* 
> {code}
> /subsystem=elytron/credential-store=CredStore108:add(uri="cr-store://test/cs108.jceks?create.storage=true",  credential-reference={clear-text=pass123}, relative-to=non.exist.path.resource)
> {code}
> *You can see this log.*
> Especially information about New missing/unsatisfied dependencies:is important and it wouldn't be there.
> {code}
> 16:54:18,809 ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 8) WFLYCTL0013: Operation ("add") failed - address: ([
>     ("subsystem" => "elytron"),
>     ("credential-store" => "CredStore108")
> ]) - failure description: {
>     "WFLYCTL0412: Required services that are not installed:" => ["jboss.server.path.\"non.exist.path.resource\""],
>     "WFLYCTL0180: Services with missing/unavailable dependencies" => ["org.wildfly.security.credential-store.CredStore108 is missing [jboss.server.path.\"non.exist.path.resource\"]"]
> }
> 16:54:18,810 INFO  [org.jboss.as.controller] (management-handler-thread - 8) WFLYCTL0183: Service status report
> WFLYCTL0184:    New missing/unsatisfied dependencies:
>       service jboss.server.path."non.exist.path.resource" (missing) dependents: [service org.wildfly.security.credential-store.CredStore108] 
> {code}
> *Now we try process same command without relative-to attribute*
> {code}
> /subsystem=elytron/credential-store=CredStore108:add(uri="cr-store://test/cs108.jceks?create.storage=true",  credential-reference={clear-text=pass123})   
> {code}
> *Result is success but we can notice this in log:*
> {code}
> 16:55:33,093 INFO  [org.jboss.as.controller] (management-handler-thread - 10) WFLYCTL0183: Service status report
> WFLYCTL0185:    Newly corrected services:
>       service jboss.server.path."non.exist.path.resource" (no longer required)
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)