[jboss-jira] [JBoss JIRA] (WFCORE-2566) Subsystem parsing tests ignores wrong END_ELEMENT

Tomaz Cerar (JIRA) issues at jboss.org
Tue Mar 21 10:35:00 EDT 2017


    [ https://issues.jboss.org/browse/WFCORE-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13381686#comment-13381686 ] 

Tomaz Cerar commented on WFCORE-2566:
-------------------------------------

Problems like one described cannot be tested automatically.
They can be tested by having different sets of xml configurations to be tested.

best thing would be to move parser to PersistentResourceXMLDescription instead of hand written one.



> Subsystem parsing tests ignores wrong END_ELEMENT
> -------------------------------------------------
>
>                 Key: WFCORE-2566
>                 URL: https://issues.jboss.org/browse/WFCORE-2566
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 3.0.0.Beta9
>            Reporter: Jan Kalina
>            Assignee: Jan Kalina
>            Priority: Minor
>
> Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
> Tests will fail only if some next element follows - its parsing fails in such case correctly.
> Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
> Because this can stay bugs like https://github.com/wildfly-security-incubator/wildfly-core/pull/85/files unnoticed.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jboss-jira mailing list