[jboss-jira] [JBoss JIRA] (ELY-1019) Elytron, ensure BSDUnixDESCryptPasswordImpl don't suffer on sign-extension bug

[Martin Choma (JIRA)]

     [ https://issues.jboss.org/browse/ELY-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Choma updated ELY-1019:
------------------------------
    Description: 
{code}
shifts += keyShifts[i];
{code}

should be also ensured by

{code}
shifts += keyShifts[i] & 0xff;
{code}

True is array keyShifts does not contain any negative value, but it doesn't neither {{IP}} or {{keyPerm}}, which are ensured ?

This follow up https://issues.jboss.org/browse/ELY-960


  was:
{code}
shifts += keyShifts[i];
{code}

should be also ensured by

{code}
shifts += keyShifts[i] & 0xff;
{code}

True is array keyShifts does not contain any negative value, but it doesn't neither {{IP}} or {{keyPerm}}, which are ensured ?

This follow up https://issues.jboss.org/browse/JBEAP-8505




> Elytron, ensure BSDUnixDESCryptPasswordImpl don't suffer on sign-extension bug
> ------------------------------------------------------------------------------
>
>                 Key: ELY-1019
>                 URL: https://issues.jboss.org/browse/ELY-1019
>             Project: WildFly Elytron
>          Issue Type: Bug
>            Reporter: Martin Choma
>            Assignee: Darran Lofthouse
>
> {code}
> shifts += keyShifts[i];
> {code}
> should be also ensured by
> {code}
> shifts += keyShifts[i] & 0xff;
> {code}
> True is array keyShifts does not contain any negative value, but it doesn't neither {{IP}} or {{keyPerm}}, which are ensured ?
> This follow up https://issues.jboss.org/browse/ELY-960



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)