[jboss-jira] [JBoss JIRA] (WFCORE-2566) Subsystem parsing tests ignores wrong END_ELEMENT

[Darran Lofthouse (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13381947#comment-13381947 ] 

Darran Lofthouse commented on WFCORE-2566:
------------------------------------------

[~honza889] I think in the short term we could possibly fix this while loop in the ElytronSubsystemParser

{code:java}
while (reader.hasNext() && reader.nextTag() != END_ELEMENT) {
{code}

Removing the reader.hasNext() check may be sufficient for the reader.nextTag to blow up if we have overshot and over parsed.




> Subsystem parsing tests ignores wrong END_ELEMENT
> -------------------------------------------------
>
>                 Key: WFCORE-2566
>                 URL: https://issues.jboss.org/browse/WFCORE-2566
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Test Suite
>    Affects Versions: 3.0.0.Beta9
>            Reporter: Jan Kalina
>            Assignee: Jan Kalina
>            Priority: Minor
>
> Tests based on *AbstractSubsystemBaseTest* ignores bugs like excessive {code}requireNoContent(reader);{code}
> Tests will fail only if some next element follows - its parsing fails in such case correctly.
> Would be better to add same check in the end of *<test>* parsing, which would check not only there is END_ELEMENT, but also that its name really equals *test*.
> Because this can stay bugs like https://github.com/wildfly-security-incubator/wildfly-core/pull/85/files unnoticed.
> Probably can be added into org.jboss.as.subsystem.test.SubsystemTestDelegate#parse(org.jboss.as.subsystem.test.AdditionalParsers, java.lang.String)



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)