[jboss-jira] [JBoss JIRA] (WFLY-8419) poll pool stats in loop instead of Thread.sleep in AbstractDatasourceCapacityPoliciesTestCase
Martin Simka (JIRA)
issues at jboss.org
Wed Mar 22 10:06:00 EDT 2017
[ https://issues.jboss.org/browse/WFLY-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Simka updated WFLY-8419:
-------------------------------
Description: There is {{Thread.sleep}} in [AbstractDatasourceCapacityPoliciesTestCase.java#L130|https://github.com/wildfly/wildfly/blob/master/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/jca/capacitypolicies/AbstractDatasourceCapacityPoliciesTestCase.java#L130] and [ResourceAdapterCapacityPoliciesTestCase.java#L148|https://github.com/wildfly/wildfly/blob/master/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/jca/capacitypolicies/ResourceAdapterCapacityPoliciesTestCase.java#L148] which is used to wait until pool is filled with expected number of connections. But it is generally better to loop around for a while until things are in the right state, and then fail if that state does not happen within a (adjustable) timeout (was: There is {{Thread.sleep}} in [AbstractDatasourceCapacityPoliciesTestCase.java#L130|https://github.com/wildfly/wildfly/blob/master/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/jca/capacitypolicies/AbstractDatasourceCapacityPoliciesTestCase.java#L130] which is used to wait until pool is filled with expected number of connections. But it is generally better to loop around for a while until things are in the right state, and then fail if that state does not happen within a (adjustable) timeout)
> poll pool stats in loop instead of Thread.sleep in AbstractDatasourceCapacityPoliciesTestCase
> ---------------------------------------------------------------------------------------------
>
> Key: WFLY-8419
> URL: https://issues.jboss.org/browse/WFLY-8419
> Project: WildFly
> Issue Type: Task
> Components: Test Suite
> Reporter: Martin Simka
> Assignee: Martin Simka
> Priority: Trivial
>
> There is {{Thread.sleep}} in [AbstractDatasourceCapacityPoliciesTestCase.java#L130|https://github.com/wildfly/wildfly/blob/master/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/jca/capacitypolicies/AbstractDatasourceCapacityPoliciesTestCase.java#L130] and [ResourceAdapterCapacityPoliciesTestCase.java#L148|https://github.com/wildfly/wildfly/blob/master/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/jca/capacitypolicies/ResourceAdapterCapacityPoliciesTestCase.java#L148] which is used to wait until pool is filled with expected number of connections. But it is generally better to loop around for a while until things are in the right state, and then fail if that state does not happen within a (adjustable) timeout
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
More information about the jboss-jira
mailing list