[jboss-jira] [JBoss JIRA] (JGRP-2165) TP.receive() should also handle InputStreams

[Bela Ban (JIRA)]

     [ https://issues.jboss.org/browse/JGRP-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bela Ban resolved JGRP-2165.
----------------------------
    Resolution: Done


> TP.receive() should also handle InputStreams
> --------------------------------------------
>
>                 Key: JGRP-2165
>                 URL: https://issues.jboss.org/browse/JGRP-2165
>             Project: JGroups
>          Issue Type: Enhancement
>            Reporter: Bela Ban
>            Assignee: Bela Ban
>             Fix For: 4.0.2
>
>
> Currently, {{TP.receive()}} is passed a byte[] buffer as parameter. This is OK for UDP and TCP_NIO2, however, in TCP we're dealing with a socket input stream.
> TcpConnection reads the length, then copies {{length}} bytes into a byte[] buffer and finally calls TP.receive() with the byte[] buffer as argument.
> The byte[] buffer and the copying of read data into it is superfluous if TP.receive() could also accept input streams as argument.
> Therefore introduce an additional {{TP.receive(InputStream in, int offset, int length}}, which reads directly from the socket's input stream and gets rid of the intermediate byte buffer.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)