[jboss-jira] [JBoss JIRA] (WFCORE-2785) The HttpDeploymentUploadUnitTestCase needs to be rewritten to use the Apache HttpClient

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403854#comment-13403854 ] 

Brian Stansberry commented on WFCORE-2785:
------------------------------------------

HttpGenericOperationUnitTestCase shouldn't be combined with the other test. They are testing different contexts (/management-upload vs /management) and tossing the test methods together is likely to lead to people missing that subtle distinction and dropping coverage.

> The HttpDeploymentUploadUnitTestCase needs to be rewritten to use the Apache HttpClient
> ---------------------------------------------------------------------------------------
>
>                 Key: WFCORE-2785
>                 URL: https://issues.jboss.org/browse/WFCORE-2785
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Test Suite
>            Reporter: James Perkins
>            Assignee: Tomaz Cerar
>
> The {{org.jboss.as.test.integration.management.http.HttpDeploymentUploadUnitTestCase}} uses the {{java.net.Authenticator.setDefault()}} to set a default authenticator. This can cause issues with tests that run after this test. The authenticator would be used after when the expectation is for the authentication to fail. This test should be converted to use the Apache {{HttpClient}} or at a minimum avoid setting a default authenticator.
> It also doesn't look like the test cleans up the deployed content which it should. Maybe the {{add-content}} request could just be moved to the {{HttpGenericOperationUnitTestCase}} which has some similar actions.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)