[jboss-jira] [JBoss JIRA] (WFLY-8335) User should be informed when switching between JDBC and journal store in transactions subsystem

[Romain Pelisse (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404274#comment-13404274 ] 

Romain Pelisse commented on WFLY-8335:
--------------------------------------


1) Issues with alternatives is now fixed:

{code:java}
            "use-hornetq-store" => {
                "type" => BOOLEAN,
                "description" => "Use the journal store for writing transaction logs. Set to true to enable and to false to use the default log store type. The default log store is normally one file system file per transaction log.It's alternative to jdbc based store.",
                "expressions-allowed" => false,
                "required" => false,
                "nillable" => true,
                "default" => false,
                "alternatives" => [
                    "use-jdbc-store",
                    "use-journal-store"
                ],...
"use-jdbc-store" => {
                "type" => BOOLEAN,
                "description" => "Use the jdbc store for writing transaction logs. Set to true to enable and to false to use the default log store type. The default log store is normally one file file per transaction log. It's alternative to journal based store.",
                "expressions-allowed" => false,
                "required" => false,
                "nillable" => true,
                "default" => false,
                "alternatives" => [
                    "use-journal-store",
                    "use-hornetq-store"
                ],
                "requires" => ["jdbc-store-datasource"],
                "access-type" => "read-write",
                "storage" => "configuration",
                "restart-required" => "jvm"
            },
            ...
         "use-journal-store" => {
                "type" => BOOLEAN,
                "description" => "Use the journal store for writing transaction logs. Set to true to enable and to false to use the default log store type. The default log store creates normally one file system file per transaction log. The journal one consists from one file for all the transactions. It's alternative to jdbc based store.",
                "expressions-allowed" => false,
                "required" => false,
                "nillable" => true,
                "default" => false,
                "alternatives" => [
                    "use-jdbc-store",
                    "use-hornetq-store"
                ],
                "access-type" => "read-write",
                "storage" => "configuration",
                "restart-required" => "jvm"
            }

{code}

2) I could not reproduce the issue with batch in both standalone and domain mode:

{code}
[standalone at localhost:9990 /] batch           
[standalone at localhost:9990 / #] /subsystem=transactions:write-attribute(name=use-journal-store,value=true)
[standalone at localhost:9990 / #] /subsystem=transactions:write-attribute(name=jdbc-store-datasource, value=java:jboss/datasources/ExampleDS)
[standalone at localhost:9990 / #] /subsystem=transactions:write-attribute(name=use-jdbc-store,value=true)
[standalone at localhost:9990 / #] run-batch 
The batch failed with the following error (you are remaining in the batch editing mode to have a chance to correct the error): 
WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:
Step: step-3
Operation: /subsystem=transactions:write-attribute(name=use-jdbc-store,value=true)
Failure: WFLYCTL0105: use-journal-store is invalid in combination with use-jdbc-store
{code}
-----
{code}
[domain at localhost:9990 /] batch 
[domain at localhost:9990 / #] /profile=default/subsystem=transactions:write-attribute(name=jdbc-store-datasource, value=java:jboss/datasources/ExampleDS)
[domain at localhost:9990 / #] /profile=default/subsystem=transactions:write-attribute(name=use-journal-store,value=true)
[domain at localhost:9990 / #] /profile=default/subsystem=transactions:write-attribute(name=use-jdbc-store,value=true)
[domain at localhost:9990 / #] run-batch 
The batch failed with the following error (you are remaining in the batch editing mode to have a chance to correct the error): {"WFLYCTL0062: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-3" => "WFLYCTL0105: use-journal-store is invalid in combination with use-jdbc-store"}}
{code}

Nevertheless I added a test for this use case in the testsuite.

> User should be informed when switching between JDBC and journal store in transactions subsystem
> -----------------------------------------------------------------------------------------------
>
>                 Key: WFLY-8335
>                 URL: https://issues.jboss.org/browse/WFLY-8335
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: Transactions
>    Affects Versions: 10.1.0.Final
>            Reporter: Romain Pelisse
>            Assignee: Romain Pelisse
>            Priority: Minor
>             Fix For: 11.0.0.Beta1
>
>   Original Estimate: 2 days
>  Remaining Estimate: 2 days
>
> Precondition: 'Use journal store' or 'Use JDBC store' was previously set to true.
> When enabling other type of store, user is not informed about the fact, that only one of those can be set and the previously enabled store is disabled and the new store is enabled without notification. User should be definitely informed about this.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)