[jboss-jira] [JBoss JIRA] (WFCORE-2746) Move elytron management security tests from full to core

[James Perkins (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405741#comment-13405741 ] 

James Perkins commented on WFCORE-2746:
---------------------------------------

There's at least a few different ways it could be dealt with. 

# The easiest would be making them separate tests. You just put the test methods in an abstract class with different {{@BeforeClass}} for each configuration.
# You could make the 4 test logic methods private, configure the correct context on the HTTP interface, then invoke each logic test method.
# This is also not my favorite, buy you could use the {{@FixMethodOrder(MethodSorters.NAME_ASCENDING)}}  annotation in JUnit. The only real benefit here is it wouldn't require a new annotation. Though I do suppose a sequence annotation is easier to read if you're looking at the test for the first time.

Don't get me wrong I think not reloading the server for each test is a good thing. I think option 1 or 2 would solve the issue with not having to add a new annotation though. If you give me the name of the test I'd be happy to have a look at it. Maybe in this case some kind of sequence annotation makes sense and I'm just missing the point. 

> Move elytron management security tests from full to core
> --------------------------------------------------------
>
>                 Key: WFCORE-2746
>                 URL: https://issues.jboss.org/browse/WFCORE-2746
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Domain Management, Security, Test Suite
>            Reporter: Brian Stansberry
>
> Since until recently the elytron subsystem wasn't part of the core feature pack, a lot of integration tests of its use ended up in the WildFly full testsuite instead of in core. This task is to get tests that are only testing core functionality moved into the core testsuite. Because that's the right thing to do, but also because it's useful in practice by eliminating a cause for messy coordinated changes to core and full such that code changes in core can be tested.
> Corresponding Wildfly JIRA: https://issues.jboss.org/browse/WFLY-8723
> There are a number of aspects to this, for which I'll create subtasks.
> Following is an initial list of tests that should be moved. *This is meant to be a living list, with things added as they are noticed.* So anyone should feel free to edit this JIRA description to add things to the list.
> -org.jboss.as.test.integration.security.perimeter.* [2]-
> -org.jboss.as.test.manualmode.mgmt.elytron.HttpMgmtInterfaceElytronAuthenticationTestCase-
> -org.jboss.as.test.integration.domain.AbstractSlaveHCAuthenticationTestCase and subclasses.[1]-
> org.jboss.as.test.integration.security.credentialreference [2]
> integration/elytron/
> [1] One subclass of this is not related to elytron but should be moved to core too. I haven't looked closely but it uses vault, which may be why it is in full. But we can use vault in the core testsuite now.
> [2] Currently using Arquillian.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)