[jboss-jira] [JBoss JIRA] (WFCORE-2746) Move elytron management security tests from full to core

[James Perkins (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406531#comment-13406531 ] 

James Perkins commented on WFCORE-2746:
---------------------------------------

I'm not sure I follow the argument against #1. The idea would be something like this:
{code:java}
abstract class AbstractTest {

    @Test
    public test1(){}
    @Test
    public test2(){}
    @Test
    public test3(){}
    @Test
    public test4(){}
}
{code}

{code:java}
@RunsWith(Arquillian.class)
@ServerSetup(Test1.ConfigureServer.class)
public class Test1 extends AbstractTest {
    public static class ConfigureServer implements ServerSetupTask {
        @Override
        public void setup(ManagementClient client) throws Exception {}
        @Override
        public void tearDown(ManagementClient client) throws Exception {}
    }
}
{code}

You'd just repeat the abstract implementation for each configuration you want to test. Again though without know which test this is I could be off basis.

> Move elytron management security tests from full to core
> --------------------------------------------------------
>
>                 Key: WFCORE-2746
>                 URL: https://issues.jboss.org/browse/WFCORE-2746
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Domain Management, Security, Test Suite
>            Reporter: Brian Stansberry
>
> Since until recently the elytron subsystem wasn't part of the core feature pack, a lot of integration tests of its use ended up in the WildFly full testsuite instead of in core. This task is to get tests that are only testing core functionality moved into the core testsuite. Because that's the right thing to do, but also because it's useful in practice by eliminating a cause for messy coordinated changes to core and full such that code changes in core can be tested.
> Corresponding Wildfly JIRA: https://issues.jboss.org/browse/WFLY-8723
> There are a number of aspects to this, for which I'll create subtasks.
> Following is an initial list of tests that should be moved. *This is meant to be a living list, with things added as they are noticed.* So anyone should feel free to edit this JIRA description to add things to the list.
> -org.jboss.as.test.integration.security.perimeter.* [2]-
> -org.jboss.as.test.manualmode.mgmt.elytron.HttpMgmtInterfaceElytronAuthenticationTestCase-
> -org.jboss.as.test.integration.domain.AbstractSlaveHCAuthenticationTestCase and subclasses.[1]-
> org.jboss.as.test.integration.security.credentialreference [2]
> integration/elytron/
> [1] One subclass of this is not related to elytron but should be moved to core too. I haven't looked closely but it uses vault, which may be why it is in full. But we can use vault in the core testsuite now.
> [2] Currently using Arquillian.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)