[jboss-jira] [JBoss JIRA] (WFCORE-2805) Use Xalan from JRE rather than our own fork

Peter Palaga (JIRA) issues at jboss.org
Fri May 19 16:41:00 EDT 2017


    [ https://issues.jboss.org/browse/WFCORE-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409240#comment-13409240 ] 

Peter Palaga commented on WFCORE-2805:
--------------------------------------

Thanks Jason,

bq. 1) Translet class loading is modular compatible - see https://issues.apache.org/jira/browse/XALANJ-2535

I'd say the [XsltClassLoadingTestCase|https://github.com/ppalaga/wildfly/commit/e8c21f47cfec3f8629786f8a66fd74b1aabfb02e#diff-3026e6d15667f64fc5ee1c95a8c6b535R98] and its [transform.xsl|https://github.com/ppalaga/wildfly/commit/e8c21f47cfec3f8629786f8a66fd74b1aabfb02e#diff-346042e84f4bd9a8e420baee771cb676R23] prove exactly what you require - that both classes from the transfromer impl as well as user code (xsltc java external functions) can be loaded from one translet.

bq. 2) Deployments can bundle their own version of a JAXP transformer impl (xalan, saxon, etc) Three deployments A, B, and C . A and B bundle different implies, and C does not. Verify the expected impl is chosen correctly

Will do.

bq. 3) Modules obtain a different JAXP impl via a dependency. Create a custom module for a special JAXP transformer impl (xalan, saxon, etc) Add a dependency on a module which defines a service. Verify the service gets the correct JAXP transformer impl

Yes, let me try this.

bq. 4) Investigate how we carry over the ability to set a container wide default JAXP impl. Currently a user can replace the transformer with any version they choose.

What is the user currently supposed to do to change the container wide default JAXP impl?

bq. We have special JAXP redirection facilities to ensure that any JAXP impl which they may choose becomes the new container default. This was necessary in the past because of limitation in the JAXP search logic, which relied on hierarchical searching, and if a cl search failed would fall back to the wrong hard coded class names, as opposed to a META-INF/services search against the JVM.

> Use Xalan from JRE rather than our own fork
> -------------------------------------------
>
>                 Key: WFCORE-2805
>                 URL: https://issues.jboss.org/browse/WFCORE-2805
>             Project: WildFly Core
>          Issue Type: Task
>            Reporter: Peter Palaga
>            Assignee: Peter Palaga
>
> As proposed by [~wolfc] we want to check if we can get rid of maintaining our own fork of Xalan.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jboss-jira mailing list