[jboss-jira] [JBoss JIRA] (WFCORE-2792) AttributeDefinition.parser is not consistently used in subclasses

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412015#comment-13412015 ] 

Brian Stansberry commented on WFCORE-2792:
------------------------------------------

Please use a separate JIRA for changing the *kernel* default behavior. The default behavior was comma delimited:

https://github.com/wildfly/wildfly-core/pull/2467/files#diff-80812afdf7f2e9804500af3f04b3642cL269

The PR corrects the implementation of that default to allow it to be overridden.

The PR for this was wrong in ElytronDefinition because it changed some attributes from hard-coded space delimited to comma delimited. The attributes should specify that they want space delimited.

> AttributeDefinition.parser is not consistently used in subclasses
> -----------------------------------------------------------------
>
>                 Key: WFCORE-2792
>                 URL: https://issues.jboss.org/browse/WFCORE-2792
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Tomaz Cerar
>             Fix For: 3.0.0.Beta24
>
>
> AttributeDefinition includes a 'parser' field but it isn't consistently used for parsing calls in subclasses. ListAttributeDefinition at least isn't using it; it hard codes splitting on ',' forcing attributes that want other delimiters to roll their own parsing (e.g. https://github.com/wildfly/wildfly-core/pull/2408/commits/a3e97f5ebadce19c768af67d1d4d109f3525179d)



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)