[jboss-jira] [JBoss JIRA] (ELY-1131) WildFly Elytron Tool, For vault command bulk-convert is missing validation for parsed values from description file.

[Ingo Weiss (JIRA)]

     [ https://issues.jboss.org/browse/ELY-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ingo Weiss reassigned ELY-1131:
-------------------------------

    Assignee: Ingo Weiss  (was: Darran Lofthouse)


> WildFly Elytron Tool, For vault command bulk-convert is missing validation for parsed values from description file.
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: ELY-1131
>                 URL: https://issues.jboss.org/browse/ELY-1131
>             Project: WildFly Elytron
>          Issue Type: Bug
>            Reporter: Hynek Švábek
>            Assignee: Ingo Weiss
>
> For vault command bulk-convert is missing validation for parsed values from description file.
> There is expected to have some kind of validation for parsed value. There must be defined which values are required and which not.
> There are these problems with required arguments:
> # omitting "alias" leads to NullPointerException
> # omitting "location" leads to incorrect tool output where is "null" value as credential store, converted file isn't created but it seems that operation was successful.
> {code}
> java -jar wildfly-elytron-tool.jar vault --bulk-convert bulk-vault-conversion-desc
> Vault (enc-dir="./test";keystore="server.store") converted to credential store "null"
> {code}
> # omitting "enc-dir" leads to incorrect tool output where is "null" value for "enc-dir" and there is created empty converted.jceks file in current directory.
> {code}
> java -jar wildfly-elytron-tool.jar vault --bulk-convert bulk-vault-conversion-desc
> Vault (enc-dir="null";keystore="server.store") converted to credential store "converted.jceks"
> {code}
> * there are more choices how to solve it:
> ## error message, because each VAULT in description file should have different value.
> ## set it to current directory 
> ## other solution
> # omitting "keystore-password" leads to NullPointerException
> *  There is expected better error message.
> # There must be defined at least one "keystore", because it is separator between
> *How to reproduce*
> Download all attachments to same location as wildfly-elytron-tool.jar update *bulk-vault-conversion-desc* file and run this command
> java -jar wildfly-elytron-tool.jar vault --bulk-convert bulk-vault-conversion-desc
> Here is example of correctly defined one vault store for convert in description file
> {code}
> # Bulk conversion descriptor
> keystore:server.store
> keystore-password:MASK-2hKo56F1a3jYGnJwhPmiF5 
> enc-dir:./test
> salt:12345678
> iteration:34
> location:converted.jceks
> alias:jboss
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)