[jboss-jira] [JBoss JIRA] (WFCORE-2880) remove-alias should fail when remove non-existent alias from credential store.

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413880#comment-13413880 ] 

Brian Stansberry commented on WFCORE-2880:
------------------------------------------

IMHO it's debatable whether this is a bug. I can see both sides of it, and for something like this where a typo in what you are removing can result in leaving something behind there's a stronger case for being strict. In general though it's quite normal for APIs to allow people to try and remove things that may not exist, since the user may not care if the thing was there, so long as it's no longer there at the end.

This also needs to consider things like the use of this operation on a /profile=x/subsystem=elytron/... resource, as that may increase the odds of the thing not being there on a particular server and the user being fine with that.

> remove-alias should fail when remove non-existent alias from credential store.
> ------------------------------------------------------------------------------
>
>                 Key: WFCORE-2880
>                 URL: https://issues.jboss.org/browse/WFCORE-2880
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Security
>            Reporter: Hynek Švábek
>            Assignee: Darran Lofthouse
>            Priority: Critical
>
> remove-alias should fail when remove non-existent alias from credential store.
> There is expected fail when we try to remove non-existent alias from credential store.
> *How to reproduce*
> *create credential store*
> {code}
> /subsystem=elytron/credential-store=cs001:add(create=true, credential-reference={clear-text=pass123},location=cs001.jceks)
> {code}
> *Try to remove alias from empty credential store*
> {code}
> /subsystem=elytron/credential-store=cs001:remove-alias(alias=alias001)
> {
>     "outcome" => "success",
>     "result" => undefined
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)