[jboss-jira] [JBoss JIRA] (WFLY-9553) PooledConnectionFactoryAdd adds a resource with no registration

[Jeff Mesnil (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489697#comment-13489697 ] 

Jeff Mesnil commented on WFLY-9553:
-----------------------------------

[~brian.stansberry] Couldn't we check if value of statistics-enabled in the populateModel method and if it's true, then install the statistics resource?

This would ensure that the resource is only modified during the MODEL stage and the runtime resource is only created when stats are actually enabled.

> PooledConnectionFactoryAdd adds a resource with no registration
> ---------------------------------------------------------------
>
>                 Key: WFLY-9553
>                 URL: https://issues.jboss.org/browse/WFLY-9553
>             Project: WildFly
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 11.0.0.Final
>            Reporter: Brian Stansberry
>            Assignee: Jeff Mesnil
>            Priority: Minor
>
> When working on WFCORE-2930 I was investigating discrepancies in mbean counts generated via the method in that fix vs current code. I discovered one in WildFly's messaging-activemq that is a result of a statistics resource being added to the resource tree even if attribute that triggers registration of the related ManagementResourceRegistration isn't set. So we have an undescribed resource.
> This likely has no other impact than a slightly inaccurate result from MBeanServerConnection.getMBeanCount() but we don't want this kind of thing anyway.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)