[jboss-jira] [JBoss JIRA] (ELY-1453) Sigtest: In public API non public class RealmDefiniteOutcomeAuthenticationEvent is used

[Martin Choma (JIRA)]

     [ https://issues.jboss.org/browse/ELY-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Choma updated ELY-1453:
------------------------------
    Description: 
SigTest check reveals:
{noformat}
Hidden class found:
org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent
in method public
{org.wildfly.security.auth.server.event.RealmEventVisitor%1}
org.wildfly.security.auth.server.event.RealmEventVisitor.handleDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent,{org.wildfly.security.auth.server.event.RealmEventVisitor%0})
in class org.wildfly.security.auth.server.event.RealmEventVisitor
{noformat}

Fix could be as easy as make RealmDefiniteOutcomeAuthenticationEvent public.

But I still left for developers judgement if make constructor of RealmDefiniteOutcomeAuthenticationEvent package private. Thus RealmDefiniteOutcomeAuthenticationEvent can't be inherited from. If that was reason for not marking this class as public originally.


  was:
SigTest check reveals:
{noformat}
Hidden class found:
org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent
in method public
{org.wildfly.security.auth.server.event.RealmEventVisitor%1}
org.wildfly.security.auth.server.event.RealmEventVisitor.handleDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent,{org.wildfly.security.auth.server.event.RealmEventVisitor%0})
in class org.wildfly.security.auth.server.event.RealmEventVisitor
{noformat}

Fix could be as easy as make RealmDefiniteOutcomeAuthenticationEvent public.

But I still left for developers justification if make constructor of RealmDefiniteOutcomeAuthenticationEvent package private. Thus RealmDefiniteOutcomeAuthenticationEvent can't be inherited from. If that was reason for not marking this class as public originally.




> Sigtest: In public API non public class RealmDefiniteOutcomeAuthenticationEvent is used
> ---------------------------------------------------------------------------------------
>
>                 Key: ELY-1453
>                 URL: https://issues.jboss.org/browse/ELY-1453
>             Project: WildFly Elytron
>          Issue Type: Bug
>          Components: API / SPI
>    Affects Versions: 1.2.0.Beta10
>            Reporter: Martin Choma
>
> SigTest check reveals:
> {noformat}
> Hidden class found:
> org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent
> in method public
> {org.wildfly.security.auth.server.event.RealmEventVisitor%1}
> org.wildfly.security.auth.server.event.RealmEventVisitor.handleDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent,{org.wildfly.security.auth.server.event.RealmEventVisitor%0})
> in class org.wildfly.security.auth.server.event.RealmEventVisitor
> {noformat}
> Fix could be as easy as make RealmDefiniteOutcomeAuthenticationEvent public.
> But I still left for developers judgement if make constructor of RealmDefiniteOutcomeAuthenticationEvent package private. Thus RealmDefiniteOutcomeAuthenticationEvent can't be inherited from. If that was reason for not marking this class as public originally.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)