[jboss-jira] [JBoss JIRA] (WFCORE-3432) Correct ManagementResourceRegistration runtime-only metadata

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494442#comment-13494442 ] 

Brian Stansberry edited comment on WFCORE-3432 at 11/27/17 6:46 PM:
--------------------------------------------------------------------

Step 1) results for core:

ServerEnvironmentResourceDescription
HostEnvironmentResourceDefinition
ModuleLoadingResourceDefinition
PatchResourceDefinition (also its children)
StoppedServerResource?
ManagedDMRContentResourceDefinition??
DiscoveryOptionsResourceDefinition???
DiscoveryOptionResourceDefinition???
StaticDiscoveryResourceDefinition???

The ones with ?, ??, ??? require a bit of thought. StoppedServerResource doesn't require much; seems obviously runtime-only. ManagedDMRContentResourceDefinition may in the end persist to the content repo and hence to the config via the hash attribute on the parent, so perhaps not really runtime only.  The discovery options stuff IIRC is an alias to persistent attributes, so again not fully runtime-only.


was (Author: brian.stansberry):
Step 1) results for core:

ServerEnvironmentResourceDescription
HostEnvironmentResourceDefinition
ModuleLoadingResourceDefinition
PatchResourceDefinition (also its children)
StoppedServerResource?
ManagedDMRContentResourceDefinition??
DiscoveryOptionsResourceDefinition???
DiscoveryOptionResourceDefinition???
StaticDiscoveryResourceDefinition???

The ones with ?, ??, ??? require a bit of thought. StoppedServerResource doesn't require much; seems obviously runtime-only. ManagedDMRContentResourceDefinition may in the end persist to the content repo and hence to the config via the sha attribute, so perhaps not really runtime only.  The discovery options stuff IIRC is an alias to persistent attributes, so again not fully runtime-only.

> Correct ManagementResourceRegistration runtime-only metadata
> ------------------------------------------------------------
>
>                 Key: WFCORE-3432
>                 URL: https://issues.jboss.org/browse/WFCORE-3432
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>
> We have MRRs, e.g. ServerEnvironmentResourceDescription, where the resources are runtime-only but the MRR.isRuntimeOnly() is not stating that.
> 3 possible aspects to this:
> 1) Audit uses of Resource.Factory.create(true[,...]) and check that those are also setting up the ResourceDefinition correctly so the MRR reports runtime-only.
> 2) Change the ConcreteResourceRegistration stuff such that it ignores the ResourceDefinition if the parent is runtime-only. IOW, runtime-only parents can't have non-runtime-only children. This would wipe out a category of possilbe errors in the setup of the children.
> 3) Have ExtensionRegistry/SubsystemRegistrationImpl ensure that the registrations for deployment resource children are runtime-only.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)