[jboss-jira] [JBoss JIRA] (WFCORE-3441) Undeprecate SubsystemRegistration.registerXMLElementWriter

Brian Stansberry (JIRA) issues at jboss.org
Thu Nov 30 16:52:00 EST 2017


Brian Stansberry created WFCORE-3441:
----------------------------------------

             Summary: Undeprecate SubsystemRegistration.registerXMLElementWriter
                 Key: WFCORE-3441
                 URL: https://issues.jboss.org/browse/WFCORE-3441
             Project: WildFly Core
          Issue Type: Task
          Components: Domain Management
            Reporter: Brian Stansberry
            Assignee: Brian Stansberry
            Priority: Minor


It's not clear that using a Supplier<XMLElementWriter> is better or even best practice, so we shouldn't push it.

1) The supplier very likely costs more metaspace, since the class being newed up in a method reference gets loaded anyway, plus the cost of the method reference.

2) Sharing the instance between the writer and the parser is more efficient for one that stores state. (Not completely trivial though, as it means the Extension impl must cache it.)

3) For non-legacy versions of the parser, we don't really want a Supplier. A Supplier defers work until the single threaded parsing phase of boot, and we want a lot of work to happen instead in the concurrently executed Extension.initializeParsers call.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)


More information about the jboss-jira mailing list