[jboss-jira] [JBoss JIRA] (WFCORE-3180) ElytronSubsystemMessages uses double quotes to surround string literals

[Yeray Borges (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471365#comment-13471365 ] 

Yeray Borges commented on WFCORE-3180:
--------------------------------------

[~brian.stansberry] just a random thought, would you be interested in a solution that works with LocalDescription.properties as well?

There are text descriptions using double quotes there. Those descriptions are "badly" scaped when they are displayed by read-resource-description for example, maybe it could be useful a general solution that takes those cases into account.

> ElytronSubsystemMessages uses double quotes to surround string literals
> -----------------------------------------------------------------------
>
>                 Key: WFCORE-3180
>                 URL: https://issues.jboss.org/browse/WFCORE-3180
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Security
>            Reporter: Brian Stansberry
>            Priority: Minor
>
> Lots of things like this:
> @Message(id = 910, value = "Password cannot be resolved for key-store \"%s\"")
> Use ' instead of \".  If the string ends up in a DMR ModelNode, which it often does, the output looks bad when double quotes are present.
> For this ModelNode
> ModelNode node = new ModelNode("Password cannot be resolved for key-store \"%s\"");
>        
> A call to node.toString() produces
> "Password cannot be resolved for key-store \"%s\""
> node.asString() is better, but that requires a special call vs the standard Object.toString
> Password cannot be resolved for key-store "%s"
> This is minor since we can try to ensure asString is used or perhaps even consider changing how toString works. But I think single quotes are a better practice.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)