[jboss-jira] [JBoss JIRA] (WFCORE-3362) Clean up type hierarchy of the kernel parser implementations
Brian Stansberry (JIRA)
issues at jboss.org
Tue Oct 17 16:28:00 EDT 2017
Brian Stansberry created WFCORE-3362:
----------------------------------------
Summary: Clean up type hierarchy of the kernel parser implementations
Key: WFCORE-3362
URL: https://issues.jboss.org/browse/WFCORE-3362
Project: WildFly Core
Issue Type: Task
Components: Domain Management
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Priority: Minor
Minor stuff I want to clean up while implementing the routine new parser work for WFCORE-3309:
1) StandaloneXml/DomainXml/HostXml should not extend CommonXml as they don't use anything from it. They should directly declare the parsing/marshaling interfaces they implement.
2) CommonXml should not declare it implements XMLElementWriter, thus freeing its many subclasses that will never be used in marshaling from needing to add a writeContent method that throws UnsupportedOperationException or does nothing. Only the current version needs to have such a method, and it doesn't need to be public or implement the interface as it's only called by the StandaloneXml/DomainXml/HostXml that's in its package.
3) Various classes can be final, various methods can be private, a few other IDE warns can be cleaned up.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
More information about the jboss-jira
mailing list