[jboss-jira] [JBoss JIRA] (WFCORE-3379) AttributeNamePathCompleter pollutes terminal by calling e.printStackTrace on CommandFormatException

[Chao Wang (JIRA)]

Chao Wang created WFCORE-3379:
---------------------------------

             Summary: AttributeNamePathCompleter pollutes terminal by calling e.printStackTrace on CommandFormatException
                 Key: WFCORE-3379
                 URL: https://issues.jboss.org/browse/WFCORE-3379
             Project: WildFly Core
          Issue Type: Bug
          Components: CLI
    Affects Versions: 3.0.8.Final
            Reporter: Chao Wang
            Assignee: Chao Wang


I run into this by accident. command: 
{noformat}
/subsystem=datasources/data-source=ExampleDS:read-attribute(name=[PRESS_TAB_HERE
{noformat}
terminal output:
{noformat}
[standalone at localhost:9990 /] /subsystem=datasources/data-source=ExampleDS:read-attribute(name=[org.jboss.as.cli.CommandFormatException: Attribute name is missing before [ at index 0 in '['
	at org.jboss.as.cli.impl.AttributeNamePathCompleter$AttributeNamePathCallbackHandler.enteredState(AttributeNamePathCompleter.java:394)
	at org.jboss.as.cli.parsing.StateParser$ParsingContextImpl.enterState(StateParser.java:297)
	at org.jboss.as.cli.parsing.EnterStateCharacterHandler.handle(EnterStateCharacterHandler.java:44)
	at org.jboss.as.cli.parsing.StateParser$ParsingContextImpl.parse(StateParser.java:139)
	at org.jboss.as.cli.parsing.StateParser.doParse(StateParser.java:106)
	at org.jboss.as.cli.parsing.StateParser.parse(StateParser.java:73)
	at org.jboss.as.cli.parsing.StateParser.parse(StateParser.java:63)
	at org.jboss.as.cli.parsing.StateParser.parse(StateParser.java:56)
	at org.jboss.as.cli.impl.AttributeNamePathCompleter.parse(AttributeNamePathCompleter.java:246)
	at org.jboss.as.cli.impl.AttributeNamePathCompleter.complete(AttributeNamePathCompleter.java:231)
	at org.jboss.as.cli.impl.AttributeNamePathCompleter.complete(AttributeNamePathCompleter.java:220)
	at org.jboss.as.cli.operation.OperationRequestCompleter.complete(OperationRequestCompleter.java:276)
	at org.jboss.as.cli.operation.OperationRequestCompleter.complete(OperationRequestCompleter.java:89)
	at org.jboss.as.cli.CommandCompleter.doComplete(CommandCompleter.java:137)
	at org.jboss.as.cli.CommandCompleter.complete(CommandCompleter.java:64)
	at org.jboss.as.cli.impl.Console$Factory$1$1.complete(Console.java:143)
	at org.jboss.aesh.console.AeshCompletionHandler.complete(AeshCompletionHandler.java:155)
	at org.jboss.aesh.console.AeshInputProcessor.complete(AeshInputProcessor.java:429)
	at org.jboss.aesh.console.AeshInputProcessor.parseOperation(AeshInputProcessor.java:166)
	at org.jboss.aesh.console.Console.processInternalOperation(Console.java:778)
	at org.jboss.aesh.console.Console.execute(Console.java:738)
	at org.jboss.aesh.console.Console.access$900(Console.java:73)
	at org.jboss.aesh.console.Console$6.run(Console.java:647)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

{noformat}
command above is an edge case when people tries incorrectly AttributeNamePathCompleter with malformed command. However, it's better to log a warning message than print exception stack trace into client terminal.



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)