[jboss-jira] [JBoss JIRA] (JGRP-2225) Allow for sending of message batches in JChannel and protocols
Bela Ban (JIRA)
issues at jboss.org
Wed Oct 25 06:26:00 EDT 2017
[ https://issues.jboss.org/browse/JGRP-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481590#comment-13481590 ]
Bela Ban commented on JGRP-2225:
--------------------------------
Hmm, quite an effort involved in this:
* All bundlers now have to handle an additional {{down(MessageBatch)}} method
* If the default impl of {{down(MessageBatch)}} in {{Protocol}} sends messages down one-by-one (calling {{down(Message)}}), then most batches will get sent down one-by-one, unless all protocols implement the {{down(MessageBatch)}} method
* If the default impl passes the batch down to the next protocol, then *all* protocols which implement {{down(Message)}} will also have to implement {{down(MessageBatch)}}, or else batches will be sent down unchanged -> this is incorrect
** This is *not* like {{up(MessageBatch)}} where the default impl removes messages from the batch relevant to it (calling {{up(Message)}} on them) and then passes the batch up, which is acceptable
[~pruivo] I think you'll have to send your ACKs to the same destination inside of a single {{Message}}, at least until I come up with a better idea on a default impl of {{down(MessageBatch)}} in {{Protocol}}...
> Allow for sending of message batches in JChannel and protocols
> --------------------------------------------------------------
>
> Key: JGRP-2225
> URL: https://issues.jboss.org/browse/JGRP-2225
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 5.0
>
>
> Currently, we receive messages and message batches, but we're not able to _send_ message batches. Investigate adding a {{JChannel.send(MessageBatch)}} and {{Protocol.down(MessageBatch)}}.
> The use case is that if we want to send 10 messages to the same destination, we currently send 10 messages. Because they're on the same thread, they;re _not_ likely to end up in the same batch.
> Sending a message batch down the stack ensures that all messages end up in the same message batch (unless the max bundle size is exceeded).
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
More information about the jboss-jira
mailing list