[jboss-jira] [JBoss JIRA] (WFLY-9324) Driver-name parameter should not be required

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-9324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460925#comment-13460925 ] 

Brian Stansberry commented on WFLY-9324:
----------------------------------------

Fixing this will be a bit of a pain, or at least require a bit of custom code.

Really, driver-name should not be declared as a parameter of the :add op at all, as its value is ultimately ignored. But, simply dropping it as a declared parameter will result in the CLI rejecting existing scripts that use it, and scripts will use it since currently the server will fail ops that don't. The CLI can be configured to not do that kind of validation, but users shouldn't have to do that.

Fixes:

1) When iterating over the parameters in the add handler, check for driver-name and don't call validateAndSet on it.

or

2) Don't include driver-name in the array of ADs that the add handler iterates over. Fragile as now there will be two arrays to keep in sync.

> Driver-name parameter should not be required
> --------------------------------------------
>
>                 Key: WFLY-9324
>                 URL: https://issues.jboss.org/browse/WFLY-9324
>             Project: WildFly
>          Issue Type: Bug
>          Components: JCA
>    Affects Versions: 11.0.0.CR1
>            Reporter: Michal Petrov
>
> Kind of a regression of AS7-4041. Currently the AttributeDefinition for {{driver-name}} is [marked as required|https://github.com/wildfly/wildfly/blob/5278ccf0cd392c2d82e96385455175ada52043ee/connector/src/main/java/org/jboss/as/connector/subsystems/datasources/Constants.java#L842] which is unnecessary since the name is taken from the operation.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)