[jboss-jira] [JBoss JIRA] (WFCORE-3259) ModelTestUtils isn't confirming the transformed boot ops work on the legacy slave

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460962#comment-13460962 ] 

Brian Stansberry commented on WFCORE-3259:
------------------------------------------

[~luck3y] Yes. Have a look at the CI run from the linked PR -- it resulted in failures in the undertow and connector modules in full. So we can't resolve this until those are fixed.

I found this when I was writing some new transformers for elytron work Jason is doing. The tests I was writing would fail in mysterious ways in checkFailedTransformedBootOperations, after the code I quoted in the description. They'd fail as the test moved on to testing write-attribute ops. The ops would fail with resource not found problems reporting there was no subsystem=elytron. That's because the problematic mainServices.executeOperation above with the boot ops was failing but the failure was ignored.

> ModelTestUtils isn't confirming the transformed boot ops work on the legacy slave
> ---------------------------------------------------------------------------------
>
>                 Key: WFCORE-3259
>                 URL: https://issues.jboss.org/browse/WFCORE-3259
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management, Test Suite
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>
> In checkFailedTransformedBootOperations:
> {code}
>         if (config.isTransformComposite()) {
>             //Transform and execute the composite
>             TransformedOperation transformedComposite = mainServices.transformOperation(modelVersion, legacyComposite);
>             if (transformedComposite.rejectOperation(successResult())) {
>                 Assert.fail(transformedComposite.getFailureDescription());
>             }
>             mainServices.executeOperation(modelVersion, transformedComposite);
>         }
> {code}
> The outcome of that "mainServices.executeOperation" is ignored, so if the transformation isn't actually producing good ops, we don't know that.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)