[jboss-jira] [JBoss JIRA] (WFCORE-3734) [Coverity] Potential Resource Leak

[Martin Choma (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Choma updated WFCORE-3734:
---------------------------------
    Description: 
Closeable Operation is not closed in:
* [1]
{code:java|title=ModelControllerClientFactoryImpl.java}
        private OperationResponse runOperation(final ModelNode operation, final OperationMessageHandler messageHandler,
                                               final OperationAttachments attachments, boolean inVmCall) {
            Operation op = attachments == null ? Operation.Factory.create(operation) : Operation.Factory.create(operation, attachments.getInputStreams(),
                    attachments.isAutoCloseStreams());
            if (inVmCall) {
                return SecurityActions.runInVm(() -> modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT));
            } else {
                return modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT);
            }
        }
{code}

* [2]
{code:java|title=AffectedDeploymentOverlay.java}
final ModelNode slave = opBuilder.build().getOperation();
{code}

[1] http://station5.brq.redhat.com:8080/reports.htm#v10078/p10031/fileInstanceId=9677771&defectInstanceId=2129457&mergedDefectId=26122
[2] http://station5.brq.redhat.com:8080/reports.htm#v10078/p10031/fileInstanceId=9679004&defectInstanceId=2129488&mergedDefectId=26012

  was:
[1] Closeable Operation is not closed in 

{code:java|title=ModelControllerClientFactoryImpl.java}
        private OperationResponse runOperation(final ModelNode operation, final OperationMessageHandler messageHandler,
                                               final OperationAttachments attachments, boolean inVmCall) {
            Operation op = attachments == null ? Operation.Factory.create(operation) : Operation.Factory.create(operation, attachments.getInputStreams(),
                    attachments.isAutoCloseStreams());
            if (inVmCall) {
                return SecurityActions.runInVm(() -> modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT));
            } else {
                return modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT);
            }
        }
{code}

[2] Closeable Operation is not closed in 
{code}

[1] http://station5.brq.redhat.com:8080/reports.htm#v10078/p10031/fileInstanceId=9677771&defectInstanceId=2129457&mergedDefectId=26122
[2] http://station5.brq.redhat.com:8080/reports.htm#v10078/p10031/fileInstanceId=9679004&defectInstanceId=2129488&mergedDefectId=26012



> [Coverity] Potential Resource Leak 
> -----------------------------------
>
>                 Key: WFCORE-3734
>                 URL: https://issues.jboss.org/browse/WFCORE-3734
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>            Reporter: Martin Choma
>            Assignee: Brian Stansberry
>            Priority: Critical
>
> Closeable Operation is not closed in:
> * [1]
> {code:java|title=ModelControllerClientFactoryImpl.java}
>         private OperationResponse runOperation(final ModelNode operation, final OperationMessageHandler messageHandler,
>                                                final OperationAttachments attachments, boolean inVmCall) {
>             Operation op = attachments == null ? Operation.Factory.create(operation) : Operation.Factory.create(operation, attachments.getInputStreams(),
>                     attachments.isAutoCloseStreams());
>             if (inVmCall) {
>                 return SecurityActions.runInVm(() -> modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT));
>             } else {
>                 return modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT);
>             }
>         }
> {code}
> * [2]
> {code:java|title=AffectedDeploymentOverlay.java}
> final ModelNode slave = opBuilder.build().getOperation();
> {code}
> [1] http://station5.brq.redhat.com:8080/reports.htm#v10078/p10031/fileInstanceId=9677771&defectInstanceId=2129457&mergedDefectId=26122
> [2] http://station5.brq.redhat.com:8080/reports.htm#v10078/p10031/fileInstanceId=9679004&defectInstanceId=2129488&mergedDefectId=26012



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)