[jboss-jira] [JBoss JIRA] (WFCORE-3734) [Coverity] Operation - Potential Resource Leak

[Brian Stansberry (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Stansberry resolved WFCORE-3734.
--------------------------------------
    Resolution: Rejected


Rejected.

1) Two unrelated pieces of code in a single bug report.

2) No reproducer for either showing an actual problem. I want proof that the attachments are not actually closed in a real use case. Just because a class can be helpful and close things for you doesn't mean you have to take advantage of its help.

> [Coverity] Operation - Potential Resource Leak 
> -----------------------------------------------
>
>                 Key: WFCORE-3734
>                 URL: https://issues.jboss.org/browse/WFCORE-3734
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>            Reporter: Martin Choma
>            Assignee: Brian Stansberry
>            Priority: Critical
>
> Closeable Operation is not closed in:
> * {code:java|title=ModelControllerClientFactoryImpl.java}
>         private OperationResponse runOperation(final ModelNode operation, final OperationMessageHandler messageHandler,
>                                                final OperationAttachments attachments, boolean inVmCall) {
>             Operation op = attachments == null ? Operation.Factory.create(operation) : Operation.Factory.create(operation, attachments.getInputStreams(),
>                     attachments.isAutoCloseStreams());
>             if (inVmCall) {
>                 return SecurityActions.runInVm(() -> modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT));
>             } else {
>                 return modelController.execute(op, messageHandler, ModelController.OperationTransactionControl.COMMIT);
>             }
>         }
> {code}
> * {code:java|title=AffectedDeploymentOverlay.java}
> final ModelNode slave = opBuilder.build().getOperation();
> {code}



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)